Skip to content

Calls order of q_invokable method #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rjcamatos wants to merge 10,000 commits into
base: 6.2
Choose a base branch
from
Open

Calls order of q_invokable method #10

rjcamatos wants to merge 10,000 commits into from

Conversation

@rjcamatos
Copy link

@rjcamatos rjcamatos commented Jul 11, 2021

If there are 2 or more methods with the same name but reciving diferent arguments the QJSEngine Pickup the First One declared.

Example:
methodxyz(string)
methodxyz(objptr*)

It picks up the first one passing as argument a string and not the one that i was expecting an object as it was send.

qtprojectorg pushed a commit that referenced this pull request Dec 8, 2023
@michaelweghorn
QmltcVisitor: Fix sort order of array used with std::binary_search
62d870d 
Using std::binary_search has the requirement that the passed
range fulfils ordering requirements, which was not the case
for the cppKeywords array here.

As the QString doc says [1]:

> QStrings can be compared using overloaded operators such as operator<(),
> operator<=(), operator==(), operator>=(), and so on. Note that
> the comparison is based exclusively on the numeric Unicode
> values of the characters. It is very fast, but is not what a
> human would expect; (...)

Therefore, sort the array accordingly and add an assert to
ensure it will remain sorted.

Fixes an crash/assert when building qtdeclarative with
CXXFLAGS='-D_GLIBCXX_DEBUG':

    /usr/include/c++/13/bits/stl_algo.h:2243:
    In function:
        bool std::binary_search(_FIter, _FIter, const _Tp&) [with _FIter = const
        QString*; _Tp = QStringView]

    Error: elements in iterator range [first, last) are not partitioned by the
    value __val.

    Objects involved in the operation:
        iterator "first" @ 0x7ffc4a2c4f18 {
          type = QString const* (constant iterator);
        }
        iterator "last" @ 0x7ffc4a2c4f10 {
          type = QString const* (constant iterator);
        }
    Aborted (core dumped)
    ninja: build stopped: subcommand failed.

GDB backtrace:

    Program terminated with signal SIGABRT, Aborted.
    #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
    44      ./nptl/pthread_kill.c: No such file or directory.
    (gdb) bt
    #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
    #1  0x00007f307e0a815f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
    #2  0x00007f307e05a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
    #3  0x00007f307e0444b2 in __GI_abort () at ./stdlib/abort.c:79
    #4  0x00007f307e2a300d in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6
    #5  0x00005639ff90471d in std::binary_search<QString const*, QStringView> (__first=0x5639ffa1a9c0 <QmltcVisitor::checkForNamingCollisionsWithCpp(QDeferredSharedPointer<QQmlJSScope const> const&)::cppKeywords>,
        __last=0x5639ffa1b2c0 <guard variable for QmltcVisitor::checkForNamingCollisionsWithCpp(QDeferredSharedPointer<QQmlJSScope const> const&)::cppKeywords>, __val=...) at /usr/include/c++/13/bits/stl_algo.h:2243
    #6  0x00005639ff8fb837 in operator() (__closure=0x7ffc4a2c52bf, word=...) at /home/michi/development/git/qt5/qtdeclarative/tools/qmltc/qmltcvisitor.cpp:764
    #7  0x00005639ff8fb89e in operator() (__closure=0x7ffc4a2c52a0, name=..., errorPrefix=...) at /home/michi/development/git/qt5/qtdeclarative/tools/qmltc/qmltcvisitor.cpp:768
    #8  0x00005639ff8fc99b in QmltcVisitor::checkForNamingCollisionsWithCpp (this=0x7ffc4a2c6070, type=...) at /home/michi/development/git/qt5/qtdeclarative/tools/qmltc/qmltcvisitor.cpp:787
    #9  0x00005639ff8f9dea in QmltcVisitor::endVisit (this=0x7ffc4a2c6070, program=0x563a002e0628) at /home/michi/development/git/qt5/qtdeclarative/tools/qmltc/qmltcvisitor.cpp:341
    #10 0x00007f307f6636fa in QQmlJS::AST::UiProgram::accept0 (this=0x563a002e0628, visitor=0x7ffc4a2c6070) at /home/michi/development/git/qt5/qtdeclarative/src/qml/parser/qqmljsast.cpp:1193
    #11 0x00007f3080159b8f in QQmlJS::AST::Node::accept (this=0x563a002e0628, visitor=0x7ffc4a2c6070)
        at /home/michi/development/git/qt5/qtbase/include/QtQml/6.7.0/QtQml/private/../../../../../../qtdeclarative/src/qml/parser/qqmljsast_p.h:272
    #12 0x00007f3080212f4b in QQmlJSTypeResolver::init (this=0x7ffc4a2c5b50, visitor=0x7ffc4a2c6070, program=0x563a002e0628) at /home/michi/development/git/qt5/qtdeclarative/src/qmlcompiler/qqmljstyperesolver.cpp:173
    #13 0x00005639ff8f0bd3 in QmltcTypeResolver::init (this=0x7ffc4a2c5b50, visitor=0x7ffc4a2c6070, program=0x563a002e0628) at /home/michi/development/git/qt5/qtdeclarative/tools/qmltc/qmltctyperesolver.cpp:19
    #14 0x00005639ff8c02d4 in main (argc=23, argv=0x7ffc4a2c7a68) at /home/michi/development/git/qt5/qtdeclarative/tools/qmltc/main.cpp:269

[1] https://doc.qt.io/qt-6/qstring.html#comparing-strings

Change-Id: I82ebbcdca4ab90155b935f9af24b3a3821134563
Reviewed-by: Sami Shalayel <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>
@cla-assistant
Copy link

cla-assistant bot commented Nov 15, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 12 committers have signed the CLA.

❌ mitchcurtis
❌ vohi
❌ Dmitrii Akshintsev
❌ Inkane
❌ iCristalrope
❌ ulfhermannqt
❌ marcmutz
❌ FriedemannKleint
❌ AhmadSamir
❌ samishalayel
❌ aavit
❌ add-uos

Dmitrii Akshintsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

qtprojectorg pushed a commit that referenced this pull request Sep 9, 2025
@mitchcurtis
tst_QQuickPopup::fadeDimmer: fix stack-use-after-scope
f8742ca 
Use dimmer as a context object rather than the test itself, which
outlives it.

The backtrace was:

    FAIL!  : tst_QQuickPopup::Basic::fadeDimmer(modal) The computed value is expected to be greater than the baseline, but is not
       Computed (opacityChangeCount): 2
       Baseline (2)                 : 2
       Loc: [/Users/mitch/dev/qt-dev2/qtdeclarative/tests/auto/quickcontrols/qquickpopup/tst_qquickpopup.cpp(2629)]
    =================================================================
    ==68826==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00016b7f7140 at pc 0x000104743c68 bp 0x00016b7ecfd0 sp 0x00016b7ecfc8
    READ of size 4 at 0x00016b7f7140 thread T0
        #0 0x000104743c64 in tst_QQuickPopup::fadeDimmer()::$_0::operator()() const tst_qquickpopup.cpp:2625
        #1 0x000104743bc0 in QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()::operator()() const qobjectdefs_impl.h:116
        #2 0x000104743b64 in void QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()>(void**, QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()&&) qobjectdefs_impl.h:65
        #3 0x000104743ab4 in QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**) qobjectdefs_impl.h:115
        #4 0x000104743930 in void QtPrivate::FunctorCallable<tst_QQuickPopup::fadeDimmer()::$_0>::call<QtPrivate::List<>, void>(tst_QQuickPopup::fadeDimmer()::$_0&, void*, void**) qobjectdefs_impl.h:337
        #5 0x000104743848 in QtPrivate::QCallableObject<tst_QQuickPopup::fadeDimmer()::$_0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) qobjectdefs_impl.h:547
        #6 0x00011694273c in QtPrivate::QSlotObjectBase::call(QObject*, void**) qobjectdefs_impl.h:461
        #7 0x000116e49454 in void doActivate<false>(QObject*, int, void**) qobject.cpp:4284
        #8 0x000116e467a0 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) qobject.cpp:4344
        #9 0x00010c1462d4 in QQuickItem::opacityChanged() moc_qquickitem.cpp:1019
        #10 0x00010c1461c8 in QQuickItem::setOpacity(double) qquickitem.cpp:6517
        #11 0x00010c168638 in QQuickItem::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) moc_qquickitem.cpp:850
        #12 0x000113847100 in QQmlPropertyData::writeProperty(QObject*, void*, QFlags<QQmlPropertyData::WriteFlag>) const qqmlpropertydata_p.h:413
        #13 0x000113c33468 in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1668
        #14 0x000113c32638 in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1326
        #15 0x000113c32390 in QQmlPropertyPrivate::writeValueProperty(QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1270
        #16 0x000113c391b4 in QQmlPropertyPrivate::write(QQmlProperty const&, QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1947
        #17 0x00010c9949ac in QQuickAnimationPropertyUpdater::setValue(double) qquickanimation.cpp:2740
        #18 0x00010c992444 in QQuickBulkValueAnimator::updateCurrentTime(int) qquickanimation.cpp:2069
        #19 0x000114345428 in QAbstractAnimationJob::setCurrentTime(int) qabstractanimationjob.cpp:481
        #20 0x000114349c3c in QAbstractAnimationJob::setState(QAbstractAnimationJob::State) qabstractanimationjob.cpp:367
        #21 0x00011434bc34 in QAbstractAnimationJob::start() qabstractanimationjob.cpp:514
        #22 0x00010c9ff568 in QQuickBehavior::write(QVariant const&) qquickbehavior.cpp:419
        #23 0x00010c9ff88c in non-virtual thunk to QQuickBehavior::write(QVariant const&) qquickbehavior.cpp
        #24 0x000113f53b7c in QQmlInterceptorMetaObject::doIntercept(QMetaObject::Call, int, void**) qqmlvmemetaobject.cpp:392
        #25 0x000113f532e4 in QQmlInterceptorMetaObject::intercept(QMetaObject::Call, int, void**) qqmlvmemetaobject_p.h:153
        #26 0x000113f59788 in QQmlVMEMetaObject::metaCall(QObject*, QMetaObject::Call, int, void**) qqmlvmemetaobject.cpp:750
        #27 0x0001138474d0 in void QQmlPropertyData::doMetacall<(QMetaObject::Call)2>(QObject*, int, void**) const qqmlpropertydata_p.h:395
        #28 0x000113847128 in QQmlPropertyData::writeProperty(QObject*, void*, QFlags<QQmlPropertyData::WriteFlag>) const qqmlpropertydata_p.h:415
        #29 0x000113c33468 in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1668
        #30 0x000113c32638 in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1326
        #31 0x000113c32390 in QQmlPropertyPrivate::writeValueProperty(QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1270
        #32 0x000113c391b4 in QQmlPropertyPrivate::write(QQmlProperty const&, QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1947
        #33 0x000113c38f84 in QQmlProperty::write(QVariant const&) const qqmlproperty.cpp:1863
        #34 0x000113c39358 in QQmlProperty::write(QObject*, QString const&, QVariant const&) qqmlproperty.cpp:1880
        #35 0x000107c1db04 in QQuickPopupPrivate::hideDimmer() qquickpopup.cpp:1290
        #36 0x000107c16a68 in QQuickPopupPrivate::prepareExitTransition() qquickpopup.cpp:821
        #37 0x000107c1e038 in QQuickPopupTransitionManager::transitionExit() qquickpopup.cpp:1326
        #38 0x000107c23fd4 in QQuickPopup::setVisible(bool) qquickpopup.cpp:2496
        #39 0x000107c104d8 in QQuickPopup::close() qquickpopup.cpp:1408
        #40 0x000107c1ba80 in QQuickPopup::setParentItem(QQuickItem*) qquickpopup.cpp:2180
        #41 0x000107c1b324 in QQuickPopupPrivate::itemDestroyed(QQuickItem*) qquickpopup.cpp:1063
        #42 0x000107c1bb8c in non-virtual thunk to QQuickPopupPrivate::itemDestroyed(QQuickItem*) qquickpopup.cpp
        #43 0x00010c117f70 in void QQuickItemPrivate::notifyChangeListeners<void (QQuickItemChangeListener::*)(QQuickItem*), QQuickItem*>(QFlags<QQuickItemPrivate::ChangeType>, void (QQuickItemChangeListener::*&&)(QQuickItem*), QQuickItem*&&) qquickitem_p.h:413
        #44 0x00010c113d7c in QQuickItem::~QQuickItem() qquickitem.cpp:2420
        #45 0x00010c50e3e8 in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #46 0x00010c4ed840 in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #47 0x00010c4ed86c in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #48 0x00010c4da1c0 in QQuickWindow::~QQuickWindow() qquickwindow.cpp:1197
        #49 0x00010c531f34 in QQuickWindowQmlImpl::~QQuickWindowQmlImpl() qquickwindowmodule.cpp:73
        #50 0x00010cf2d4f4 in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:104
        #51 0x00010cf2d3e0 in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:102
        #52 0x00010cf2d40c in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:102
        #53 0x00010472efa8 in QScopedPointerDeleter<QObject>::cleanup(QObject*) qscopedpointer.h:24
        #54 0x00010472eefc in QScopedPointer<QObject, QScopedPointerDeleter<QObject>>::~QScopedPointer() qscopedpointer.h:81
        #55 0x00010466f0e8 in QScopedPointer<QObject, QScopedPointerDeleter<QObject>>::~QScopedPointer() qscopedpointer.h:79
        #56 0x00010471246c in QQuickVisualTestUtils::QQuickApplicationHelper::~QQuickApplicationHelper() visualtestutils_p.h:192
        #57 0x00010468ff88 in QQuickVisualTestUtils::QQuickApplicationHelper::~QQuickApplicationHelper() visualtestutils_p.h:192
        #58 0x0001046a953c in tst_QQuickPopup::fadeDimmer() tst_qquickpopup.cpp:2635
        [...]

Amends ef8bde8.

Pick-to: 6.8 6.9 6.10
Change-Id: Ie5c49b7d9ecd3c74f822590d296062b516563391
Reviewed-by: Volker Hilsheimer <[email protected]>
qtprojectorg pushed a commit that referenced this pull request Sep 12, 2025
@mitchcurtis
tst_QQuickPopup::fadeDimmer: fix stack-use-after-scope
cc726a4 
Use dimmer as a context object rather than the test itself, which
outlives it.

The backtrace was:

    FAIL!  : tst_QQuickPopup::Basic::fadeDimmer(modal) The computed value is expected to be greater than the baseline, but is not
       Computed (opacityChangeCount): 2
       Baseline (2)                 : 2
       Loc: [/Users/mitch/dev/qt-dev2/qtdeclarative/tests/auto/quickcontrols/qquickpopup/tst_qquickpopup.cpp(2629)]
    =================================================================
    ==68826==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00016b7f7140 at pc 0x000104743c68 bp 0x00016b7ecfd0 sp 0x00016b7ecfc8
    READ of size 4 at 0x00016b7f7140 thread T0
        #0 0x000104743c64 in tst_QQuickPopup::fadeDimmer()::$_0::operator()() const tst_qquickpopup.cpp:2625
        #1 0x000104743bc0 in QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()::operator()() const qobjectdefs_impl.h:116
        #2 0x000104743b64 in void QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()>(void**, QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()&&) qobjectdefs_impl.h:65
        #3 0x000104743ab4 in QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**) qobjectdefs_impl.h:115
        #4 0x000104743930 in void QtPrivate::FunctorCallable<tst_QQuickPopup::fadeDimmer()::$_0>::call<QtPrivate::List<>, void>(tst_QQuickPopup::fadeDimmer()::$_0&, void*, void**) qobjectdefs_impl.h:337
        #5 0x000104743848 in QtPrivate::QCallableObject<tst_QQuickPopup::fadeDimmer()::$_0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) qobjectdefs_impl.h:547
        #6 0x00011694273c in QtPrivate::QSlotObjectBase::call(QObject*, void**) qobjectdefs_impl.h:461
        #7 0x000116e49454 in void doActivate<false>(QObject*, int, void**) qobject.cpp:4284
        #8 0x000116e467a0 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) qobject.cpp:4344
        #9 0x00010c1462d4 in QQuickItem::opacityChanged() moc_qquickitem.cpp:1019
        #10 0x00010c1461c8 in QQuickItem::setOpacity(double) qquickitem.cpp:6517
        #11 0x00010c168638 in QQuickItem::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) moc_qquickitem.cpp:850
        #12 0x000113847100 in QQmlPropertyData::writeProperty(QObject*, void*, QFlags<QQmlPropertyData::WriteFlag>) const qqmlpropertydata_p.h:413
        #13 0x000113c33468 in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1668
        #14 0x000113c32638 in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1326
        #15 0x000113c32390 in QQmlPropertyPrivate::writeValueProperty(QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1270
        #16 0x000113c391b4 in QQmlPropertyPrivate::write(QQmlProperty const&, QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1947
        #17 0x00010c9949ac in QQuickAnimationPropertyUpdater::setValue(double) qquickanimation.cpp:2740
        #18 0x00010c992444 in QQuickBulkValueAnimator::updateCurrentTime(int) qquickanimation.cpp:2069
        #19 0x000114345428 in QAbstractAnimationJob::setCurrentTime(int) qabstractanimationjob.cpp:481
        #20 0x000114349c3c in QAbstractAnimationJob::setState(QAbstractAnimationJob::State) qabstractanimationjob.cpp:367
        #21 0x00011434bc34 in QAbstractAnimationJob::start() qabstractanimationjob.cpp:514
        #22 0x00010c9ff568 in QQuickBehavior::write(QVariant const&) qquickbehavior.cpp:419
        #23 0x00010c9ff88c in non-virtual thunk to QQuickBehavior::write(QVariant const&) qquickbehavior.cpp
        #24 0x000113f53b7c in QQmlInterceptorMetaObject::doIntercept(QMetaObject::Call, int, void**) qqmlvmemetaobject.cpp:392
        #25 0x000113f532e4 in QQmlInterceptorMetaObject::intercept(QMetaObject::Call, int, void**) qqmlvmemetaobject_p.h:153
        #26 0x000113f59788 in QQmlVMEMetaObject::metaCall(QObject*, QMetaObject::Call, int, void**) qqmlvmemetaobject.cpp:750
        #27 0x0001138474d0 in void QQmlPropertyData::doMetacall<(QMetaObject::Call)2>(QObject*, int, void**) const qqmlpropertydata_p.h:395
        #28 0x000113847128 in QQmlPropertyData::writeProperty(QObject*, void*, QFlags<QQmlPropertyData::WriteFlag>) const qqmlpropertydata_p.h:415
        #29 0x000113c33468 in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1668
        #30 0x000113c32638 in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1326
        #31 0x000113c32390 in QQmlPropertyPrivate::writeValueProperty(QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1270
        #32 0x000113c391b4 in QQmlPropertyPrivate::write(QQmlProperty const&, QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1947
        #33 0x000113c38f84 in QQmlProperty::write(QVariant const&) const qqmlproperty.cpp:1863
        #34 0x000113c39358 in QQmlProperty::write(QObject*, QString const&, QVariant const&) qqmlproperty.cpp:1880
        #35 0x000107c1db04 in QQuickPopupPrivate::hideDimmer() qquickpopup.cpp:1290
        #36 0x000107c16a68 in QQuickPopupPrivate::prepareExitTransition() qquickpopup.cpp:821
        #37 0x000107c1e038 in QQuickPopupTransitionManager::transitionExit() qquickpopup.cpp:1326
        #38 0x000107c23fd4 in QQuickPopup::setVisible(bool) qquickpopup.cpp:2496
        #39 0x000107c104d8 in QQuickPopup::close() qquickpopup.cpp:1408
        #40 0x000107c1ba80 in QQuickPopup::setParentItem(QQuickItem*) qquickpopup.cpp:2180
        #41 0x000107c1b324 in QQuickPopupPrivate::itemDestroyed(QQuickItem*) qquickpopup.cpp:1063
        #42 0x000107c1bb8c in non-virtual thunk to QQuickPopupPrivate::itemDestroyed(QQuickItem*) qquickpopup.cpp
        #43 0x00010c117f70 in void QQuickItemPrivate::notifyChangeListeners<void (QQuickItemChangeListener::*)(QQuickItem*), QQuickItem*>(QFlags<QQuickItemPrivate::ChangeType>, void (QQuickItemChangeListener::*&&)(QQuickItem*), QQuickItem*&&) qquickitem_p.h:413
        #44 0x00010c113d7c in QQuickItem::~QQuickItem() qquickitem.cpp:2420
        #45 0x00010c50e3e8 in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #46 0x00010c4ed840 in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #47 0x00010c4ed86c in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #48 0x00010c4da1c0 in QQuickWindow::~QQuickWindow() qquickwindow.cpp:1197
        #49 0x00010c531f34 in QQuickWindowQmlImpl::~QQuickWindowQmlImpl() qquickwindowmodule.cpp:73
        #50 0x00010cf2d4f4 in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:104
        #51 0x00010cf2d3e0 in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:102
        #52 0x00010cf2d40c in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:102
        #53 0x00010472efa8 in QScopedPointerDeleter<QObject>::cleanup(QObject*) qscopedpointer.h:24
        #54 0x00010472eefc in QScopedPointer<QObject, QScopedPointerDeleter<QObject>>::~QScopedPointer() qscopedpointer.h:81
        #55 0x00010466f0e8 in QScopedPointer<QObject, QScopedPointerDeleter<QObject>>::~QScopedPointer() qscopedpointer.h:79
        #56 0x00010471246c in QQuickVisualTestUtils::QQuickApplicationHelper::~QQuickApplicationHelper() visualtestutils_p.h:192
        #57 0x00010468ff88 in QQuickVisualTestUtils::QQuickApplicationHelper::~QQuickApplicationHelper() visualtestutils_p.h:192
        #58 0x0001046a953c in tst_QQuickPopup::fadeDimmer() tst_qquickpopup.cpp:2635
        [...]

Amends ef8bde8.

Pick-to: 6.9 6.8
Change-Id: Ie5c49b7d9ecd3c74f822590d296062b516563391
Reviewed-by: Volker Hilsheimer <[email protected]>
(cherry picked from commit f8742ca)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>
qtprojectorg pushed a commit that referenced this pull request Sep 12, 2025
@mitchcurtis
tst_QQuickPopup::fadeDimmer: fix stack-use-after-scope
2f28824 
Use dimmer as a context object rather than the test itself, which
outlives it.

The backtrace was:

    FAIL!  : tst_QQuickPopup::Basic::fadeDimmer(modal) The computed value is expected to be greater than the baseline, but is not
       Computed (opacityChangeCount): 2
       Baseline (2)                 : 2
       Loc: [/Users/mitch/dev/qt-dev2/qtdeclarative/tests/auto/quickcontrols/qquickpopup/tst_qquickpopup.cpp(2629)]
    =================================================================
    ==68826==ERROR: AddressSanitizer: stack-use-after-scope on address 0x00016b7f7140 at pc 0x000104743c68 bp 0x00016b7ecfd0 sp 0x00016b7ecfc8
    READ of size 4 at 0x00016b7f7140 thread T0
        #0 0x000104743c64 in tst_QQuickPopup::fadeDimmer()::$_0::operator()() const tst_qquickpopup.cpp:2625
        #1 0x000104743bc0 in QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()::operator()() const qobjectdefs_impl.h:116
        #2 0x000104743b64 in void QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()>(void**, QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**)::'lambda'()&&) qobjectdefs_impl.h:65
        #3 0x000104743ab4 in QtPrivate::FunctorCall<std::__1::integer_sequence<unsigned long>, QtPrivate::List<>, void, tst_QQuickPopup::fadeDimmer()::$_0>::call(tst_QQuickPopup::fadeDimmer()::$_0&, void**) qobjectdefs_impl.h:115
        #4 0x000104743930 in void QtPrivate::FunctorCallable<tst_QQuickPopup::fadeDimmer()::$_0>::call<QtPrivate::List<>, void>(tst_QQuickPopup::fadeDimmer()::$_0&, void*, void**) qobjectdefs_impl.h:337
        #5 0x000104743848 in QtPrivate::QCallableObject<tst_QQuickPopup::fadeDimmer()::$_0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) qobjectdefs_impl.h:547
        #6 0x00011694273c in QtPrivate::QSlotObjectBase::call(QObject*, void**) qobjectdefs_impl.h:461
        #7 0x000116e49454 in void doActivate<false>(QObject*, int, void**) qobject.cpp:4284
        #8 0x000116e467a0 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) qobject.cpp:4344
        #9 0x00010c1462d4 in QQuickItem::opacityChanged() moc_qquickitem.cpp:1019
        #10 0x00010c1461c8 in QQuickItem::setOpacity(double) qquickitem.cpp:6517
        #11 0x00010c168638 in QQuickItem::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) moc_qquickitem.cpp:850
        #12 0x000113847100 in QQmlPropertyData::writeProperty(QObject*, void*, QFlags<QQmlPropertyData::WriteFlag>) const qqmlpropertydata_p.h:413
        #13 0x000113c33468 in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1668
        #14 0x000113c32638 in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1326
        #15 0x000113c32390 in QQmlPropertyPrivate::writeValueProperty(QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1270
        #16 0x000113c391b4 in QQmlPropertyPrivate::write(QQmlProperty const&, QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1947
        #17 0x00010c9949ac in QQuickAnimationPropertyUpdater::setValue(double) qquickanimation.cpp:2740
        #18 0x00010c992444 in QQuickBulkValueAnimator::updateCurrentTime(int) qquickanimation.cpp:2069
        #19 0x000114345428 in QAbstractAnimationJob::setCurrentTime(int) qabstractanimationjob.cpp:481
        #20 0x000114349c3c in QAbstractAnimationJob::setState(QAbstractAnimationJob::State) qabstractanimationjob.cpp:367
        #21 0x00011434bc34 in QAbstractAnimationJob::start() qabstractanimationjob.cpp:514
        #22 0x00010c9ff568 in QQuickBehavior::write(QVariant const&) qquickbehavior.cpp:419
        #23 0x00010c9ff88c in non-virtual thunk to QQuickBehavior::write(QVariant const&) qquickbehavior.cpp
        #24 0x000113f53b7c in QQmlInterceptorMetaObject::doIntercept(QMetaObject::Call, int, void**) qqmlvmemetaobject.cpp:392
        #25 0x000113f532e4 in QQmlInterceptorMetaObject::intercept(QMetaObject::Call, int, void**) qqmlvmemetaobject_p.h:153
        #26 0x000113f59788 in QQmlVMEMetaObject::metaCall(QObject*, QMetaObject::Call, int, void**) qqmlvmemetaobject.cpp:750
        #27 0x0001138474d0 in void QQmlPropertyData::doMetacall<(QMetaObject::Call)2>(QObject*, int, void**) const qqmlpropertydata_p.h:395
        #28 0x000113847128 in QQmlPropertyData::writeProperty(QObject*, void*, QFlags<QQmlPropertyData::WriteFlag>) const qqmlpropertydata_p.h:415
        #29 0x000113c33468 in QQmlPropertyPrivate::write(QObject*, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1668
        #30 0x000113c32638 in QQmlPropertyPrivate::writeValueProperty(QObject*, QQmlPropertyData const&, QQmlPropertyData const&, QVariant const&, QQmlRefPointer<QQmlContextData> const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1326
        #31 0x000113c32390 in QQmlPropertyPrivate::writeValueProperty(QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1270
        #32 0x000113c391b4 in QQmlPropertyPrivate::write(QQmlProperty const&, QVariant const&, QFlags<QQmlPropertyData::WriteFlag>) qqmlproperty.cpp:1947
        #33 0x000113c38f84 in QQmlProperty::write(QVariant const&) const qqmlproperty.cpp:1863
        #34 0x000113c39358 in QQmlProperty::write(QObject*, QString const&, QVariant const&) qqmlproperty.cpp:1880
        #35 0x000107c1db04 in QQuickPopupPrivate::hideDimmer() qquickpopup.cpp:1290
        #36 0x000107c16a68 in QQuickPopupPrivate::prepareExitTransition() qquickpopup.cpp:821
        #37 0x000107c1e038 in QQuickPopupTransitionManager::transitionExit() qquickpopup.cpp:1326
        #38 0x000107c23fd4 in QQuickPopup::setVisible(bool) qquickpopup.cpp:2496
        #39 0x000107c104d8 in QQuickPopup::close() qquickpopup.cpp:1408
        #40 0x000107c1ba80 in QQuickPopup::setParentItem(QQuickItem*) qquickpopup.cpp:2180
        #41 0x000107c1b324 in QQuickPopupPrivate::itemDestroyed(QQuickItem*) qquickpopup.cpp:1063
        #42 0x000107c1bb8c in non-virtual thunk to QQuickPopupPrivate::itemDestroyed(QQuickItem*) qquickpopup.cpp
        #43 0x00010c117f70 in void QQuickItemPrivate::notifyChangeListeners<void (QQuickItemChangeListener::*)(QQuickItem*), QQuickItem*>(QFlags<QQuickItemPrivate::ChangeType>, void (QQuickItemChangeListener::*&&)(QQuickItem*), QQuickItem*&&) qquickitem_p.h:413
        #44 0x00010c113d7c in QQuickItem::~QQuickItem() qquickitem.cpp:2420
        #45 0x00010c50e3e8 in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #46 0x00010c4ed840 in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #47 0x00010c4ed86c in QQuickRootItem::~QQuickRootItem() qquickwindow_p.h:62
        #48 0x00010c4da1c0 in QQuickWindow::~QQuickWindow() qquickwindow.cpp:1197
        #49 0x00010c531f34 in QQuickWindowQmlImpl::~QQuickWindowQmlImpl() qquickwindowmodule.cpp:73
        #50 0x00010cf2d4f4 in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:104
        #51 0x00010cf2d3e0 in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:102
        #52 0x00010cf2d40c in QQmlPrivate::QQmlElement<QQuickWindowQmlImpl>::~QQmlElement() qqmlprivate.h:102
        #53 0x00010472efa8 in QScopedPointerDeleter<QObject>::cleanup(QObject*) qscopedpointer.h:24
        #54 0x00010472eefc in QScopedPointer<QObject, QScopedPointerDeleter<QObject>>::~QScopedPointer() qscopedpointer.h:81
        #55 0x00010466f0e8 in QScopedPointer<QObject, QScopedPointerDeleter<QObject>>::~QScopedPointer() qscopedpointer.h:79
        #56 0x00010471246c in QQuickVisualTestUtils::QQuickApplicationHelper::~QQuickApplicationHelper() visualtestutils_p.h:192
        #57 0x00010468ff88 in QQuickVisualTestUtils::QQuickApplicationHelper::~QQuickApplicationHelper() visualtestutils_p.h:192
        #58 0x0001046a953c in tst_QQuickPopup::fadeDimmer() tst_qquickpopup.cpp:2635
        [...]

Amends ef8bde8.

Pick-to: 6.8
Change-Id: Ie5c49b7d9ecd3c74f822590d296062b516563391
Reviewed-by: Volker Hilsheimer <[email protected]>
(cherry picked from commit f8742ca)
Reviewed-by: Qt Cherry-pick Bot <[email protected]>
(cherry picked from commit cc726a4)
alpqr and others added 25 commits December 5, 2025 12:32
@alpqr
Add notes to Animator docs
3628bb3 
Change-Id: I2a985ab1900afb8c027405fb0ec76c250c7535e0
Reviewed-by: Mitch Curtis <[email protected]>
@samishalayel
qqmlcodemodel: use valueAsAbsolutePathlist instead of duplicating code
1e7ed2f 
Use valueAsAbsolutePathlist instead of duplicating code in
buildPathsForFileUrl().

Change-Id: Ia2db7356efe8401178f28b55f72d3c113dbbe6f3
Reviewed-by: Fabian Kosmale <[email protected]>
@samishalayel
doc: update qmlls documentation
cacc7cc 
The setup part is mainly meant for qmlls client developers, so mark it
as such. Add the download links to the standalone qmlls, in addition to
qmlls's location inside of qt. Also document that build directories can
be passed via an LSP extension, to support multiple workspaces.

Remove the parts about import paths and documentation directories, those
are handled by CMake's .qmlls.build.ini and can lead to weird behaviors
when set incorrectly.

Change-Id: I59496d20a9d02504636af6374818260c1e5f622d
Reviewed-by: Leena Miettinen <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>
@iCristalrope
QML: Pipe objects' metaObjectHash to qqmljsscope through the qmltypes
b0bf54b 
It gets added to the json output of moc for every object. Include it in
the object's qmltypes representation too and add it to the corresponding
qqmljsscope when parsing them.

Task-number: QTBUG-142186
Change-Id: Id551a4edb1284018dee8d9afbe3b7189660478b8
Reviewed-by: Sami Shalayel <[email protected]>
StyleKit: add spacing to TooBar.qml
1c646dc 
The ToolBar missed a binding to spacing.

A ToolBar doesn't actually layout its items, the
application is responsible for that. Still, it might
want to query the spacing set from the style for
doing the layout.

Change-Id: I1613ba519e8edaeb58fe2b4cc6f7e5599dd02dff
Reviewed-by: Doris Verria <[email protected]>
StyleKit: respect theme palette
2bd0f8b 
A Qt Quick Control will use StyleKitControl.text.color as its
text color. But as it stood, it was not initialized to anything
in the FallbackStyle. The result was that all controls got a black
text color, regardless of what was set in the theme palette. It
would also not respect any palette overrides done from the app.

This patch will make sure that we, by default, bind text.color
for the various control types to the matching color in the
Qt Quick Control's palette. This color will, unless overriden by
the app, be initialized to the color set by the theme.

Change-Id: I6d4f67c81c57c9a30940a720816fa4ed2675b8bd
Reviewed-by: Doris Verria <[email protected]>
@dorisverria1
StyleKit: Add ToolSeparator
c210717 
Change-Id: If1285165aa28fea401bbff061fcdfd4563bce334
Reviewed-by: Richard Moe Gustavsen <[email protected]>
@dorisverria1
StyleKit: Add ApplicationWindow
687bbe8 
Change-Id: I9cc429c5a5e229983cb68648df239260903a0af4
Reviewed-by: Richard Moe Gustavsen <[email protected]>
@ulfhermannqt
QtQml: Invalidate fallback lookups after each call from AOT code
9af6d2d 
Fallback property lookups are created for completely dynamic
metaobjects. Anything about them may change between any two calls.

Pick-to: 6.10 6.8 6.5
Fixes: QTBUG-142331
Change-Id: Ib732c37a6f27ab8105bea0eeae000af7eb9c36d7
Reviewed-by: Sami Shalayel <[email protected]>
@ulfhermannqt
QtQml: Optimize fallback lookups a bit
5f94ff6 
We don't need to repeatedly query the metaobject for its properties just
to determine the type. We can instead store the type right away. The
same holds for the "resettable" flag.

Task-number: QTBUG-142331
Change-Id: Ia8bb96587a344a2981e766e4bc2f13bcac7b4561
Reviewed-by: Sami Shalayel <[email protected]>
@samishalayel
tst_qmlls_modules: dont segfault on test failure
7288db7 
Fix the cleanup method to disconnect the signals in m_server, otherwise
m_server might use an outdated m_protocol in a later test case.

Change-Id: I4ae3b02bc0ed5cae585dc637c037e56bc4976adf
Reviewed-by: Ulf Hermann <[email protected]>
@samishalayel
qmlls: don't use build directories as import paths
8c93c5e 
Don't mix build and import paths in qmlls. Use build paths for build
path operation (finding .qmlls.build.ini, eventually resource files,
CMake invocations, ...) and the import paths for imports (when linting
and constructing the DOM). Only use build paths as import paths as a
fallback, for projects running on Qt < 6.10.

It turns out that our tests were making heavy use of "build folders are
import paths". Modernize the tst_qmlls_modules tests to write a
.qmlls.build.ini file in the build folder which contains the import paths.

Also don't read the import path twice from the qmlls.build.ini file, and
read it from the QQmlCodeModelManager, not the QQmlCodeModel. Add a test
for importPathsForFileUrl() that used to duplicate the import paths.

Task-number: QTBUG-141707
Change-Id: I9eceb743bf37bc0f743954a0e7b1e5831f1989fa
Reviewed-by: Ulf Hermann <[email protected]>
@samishalayel
qmlls: read resource files from .qmlls.build.ini files
f9fd493 
We can't find resource files by iterating on the build folder without
causing QTBUG-141707, therefore implement reading resource files from
the .qmlls.build.ini files. A later commit will make CMake add the
resource file information in the generated .qmlls.build.ini files.

A separate commit will take care of usages of
resourceFilesFromBuildFolders() in the dom.

Keep a fallback for projects without resource files, for example
projects targeting qt < 6.11.

Task-number: QTBUG-141707
Change-Id: I279d193aa6a2849526c2f56c6a40e83492050f74
Reviewed-by: Ulf Hermann <[email protected]>
@samishalayel
qmlls: use resource files from CMake for the DOM
7704edb 
We can use the resource files from the .qmlls.build.ini also when
constructing the DOM, instead of iterating over the build and import
folders.

Fix and rename a test in tst_qmldomitem.

Task-number: QTBUG-141707
Change-Id: I9dcbd4cd307aba251e5de1d8c00c97b22dd87eb4
Reviewed-by: Ulf Hermann <[email protected]>
@vohi
Windows style: override the application palette when in dark mode
672ad85 
The native Windows (XP) styling code cannot render controls in the dark
color scheme. Our code detects that the application is running in dark
mode, and then explicitly creates a light palette that gets set on the
QQuickTheme singleton.

However, the palette that the style is actually using isn't always based
on the QQuickTheme palette, so we get inconsistent colors: the window
background is dark, a button font is light, while the button itself is
also light. This makes the UI unusable.

QGuiApp has no knowledge of Qt Quick's styling infrastructure, or of
QQuickTheme, so it cannot ask the style to "polish" the palette like we
do in widgets.

As a quick fix, override the global QGuiApplication palette with the
light palette.

[ChangeLog][Controls] The Windows native style will use a light palette
as the application global palette on Windows systems running in dark
mode. The style cannot render dark controls, and mixing a dark
application palette with some UI elements rendered in light mode using
the Control style results in inconsistent and unusable user interfaces.
For Dark mode UIs, use a style that supports dark mode, like the
FluentWinUI3 or Fusion styles.

Pick-to: 6.10 6.8
Change-Id: I5e279b88ba018baa03936624e07f48e8986eb1c6
Reviewed-by: Oliver Eftevaag <[email protected]>
StyleKit Example: improve the example after recent StyleKit fixes
d59d7b9 
Change-Id: I01bcdaea8a7014c3bd2f1c65b7d00a048700b91f
Reviewed-by: Doris Verria <[email protected]>
Update default values for {Ellipse,Star,Rectangle,RegularPolygon}Shape
196a81a 
Set the same width, height, fillColor, strokeColor and strokeWidth
values for rectangle, star, ellipse and regular polygon shapes

Task-number: QTBUG-142450
Change-Id: I1920d22e80944ee4f220b927b4c1fcbbe2bb077a
Reviewed-by: Henning Gründl <[email protected]>
@mitchcurtis
Improve easingCurve value type documentation
38a04e5 
- Reference the structured value type page.
- Fix errors in snippet and text.

Change-Id: I16eeb0f8c2d9d9d3f36ea0d0fe34087b7330a9c4
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
@andreaseliasson
Neutralize 'Best Practices for QML and Qt Quick' page
e528991 
Re-write in such a way that there's room for other backend languages
to be included on the page.

* Re-write introductory section about separating UI logic from
  business logic, replacing C++ references with the more general
  "strongly typed language".

* Keep section "Exposing Data from C++ to QML" as it's still valuable.

Fixes: QTBUG-142007
Pick-to: 6.10
Change-Id: Icb94d354ad3b2bf913c202e74174aee7c31036b4
Reviewed-by: Alexei Cazacov <[email protected]>
@ulfhermannqt
tst_qmltyperegistrar: Fix metaObjectHash regular expression
fc045b4 
We've added a version to the hash.

Fixes: QTBUG-142529
Pick-to: 6.11
Change-Id: Idba7608708db938c3cf958e98bb6ea0ea3bd7bdc
Reviewed-by: Olivier De Cannière <[email protected]>
@AhmadSamir
Port Q_{ENUMS,FLAGS} to Q_{ENUM,FLAG}
07a889f 
Q_{ENUM,FLAG} does what Q_{ENUMS,FLAGS} did plus declaring two friend
functions, so the behavior should be the same.

For enums that are declared as flags (with Q_DECLARE_FLAGS(Es, E)), use
Q_FLAG(Es) which will register each enum value with the meta-object
system.

Q_FLAGS usage in tests/auto/qml/qmlcppcodegen/data/enumproblems.h is
testing Q_FLAGS itself.

Q_ENUMS/Q_FLAGS have been deprecated since at least Qt 6.

Pick-to: 6.11 6.10 6.8 6.5
Change-Id: Id21b6e3205a786b3a5fa04bd09dfee2a6c1c2a86
Reviewed-by: Ulf Hermann <[email protected]>
@ec1oud
Stabilize tst_QQuickContextMenu::iOS::textControlsMenuKey
1e29978 
Avoid positioning items at fractional positions and then testing with a
QContextMenuEvent at 0, 0 relative to the item: it may be outside the
item by a fraction of a pixel and fail to "hit" during delivery.

Pick-to: 6.11
Change-Id: I0f1f98a7ae88a23356026d2c6c7eeb4bf2a72a92
Reviewed-by: Mitch Curtis <[email protected]>
@vohi
Fix documentation syntax
b68e5db 
Pick-to: 6.11 6.10 6.9
Change-Id: I3da95e29f642224067307a64450b80154c10cb82
Reviewed-by: Volker Hilsheimer <[email protected]>
@eskilblomfeldt
test: Run qquickvectorimage test even on non-developer builds
646385b 
The equivalent test is run on Lottie without developer build set,
so it should be fine to do this. The condition here was just
cargo culted from other CMakeLists and is not needed.

Pick-to: 6.10 6.11
Change-Id: Ib05c586b6ca8481eee312afbae7f003f51a389ce
Reviewed-by: Hatem ElKharashy <[email protected]>
@alcazaco
Doc: Overhaul the descriptions of examples about hybrid UI
11f9fe5 
The examples that demonstrate hybrid UI approaches lack proper
descriptions. This commit restructures and enhances the descriptions
for these.

Task-number: QTBUG-134102
Pick-to: 6.11 6.10
Change-Id: I5cf604fee932024cbe73347696e19f9c6e22d5b7
Reviewed-by: Alexei Cazacov <[email protected]>
iCristalrope and others added 30 commits January 13, 2026 10:42
@iCristalrope
qmllint: Remove LoggerCategory isDefault but add isEssential
6dc1452 
We want the user to have more control over which categories are enabled
and at which severity when linting. The default flag prevents the user
from doing that. Get rid of it and allow the user to change the severity
of categories both up and down.

In order for qmllint to function properly, some categegories are still
required. Mark them as essential. The only such category at the moment
is qmlSyntax. Without it, other categories might fail and silently
misbehave.

Task-number: QTBUG-141233
Change-Id: I458c6b728e3933cd0dcd855052e137f667a75c94
Reviewed-by: Semih Yavuz <[email protected]>
@add-uos
QtQml: Handle invalid application timestamp in QML cache verification
fa37d5a 
When QML source files are loaded from the resource system, we fall back to
the application executable's last modified timestamp for cache validation.
If this timestamp is invalid, we now properly report an error instead of
proceeding with invalid data.

Change-Id: I5516af312aca69c7875b2cdc43258cc1be862974
Reviewed-by: Ulf Hermann <[email protected]>
@ulfhermannqt
QtQml: Fix corner cases around dead contexts in AOT adapter code
e9f0234 
When trying to call methods in contexts that have already been torn
down, interesting things happen. We need to check the return value of
the lookup getter in various places and throw the appropriate
exceptions.

We do not actually need to reset the lookups when that happens. In a
different context they can still be valid. Instead of resetting them, we
now check in both, the initialization and the actual call.

Amends commit 4381eaf.

Pick-to: 6.11 6.10
Task-number: QTBUG-142514
Change-Id: Id8dc5079cdfe600310294046f35815c0c4bcba20
Reviewed-by: Fabian Kosmale <[email protected]>
@ulfhermannqt
QtQml: Do not clear objects' propertyCaches on last GC run
dc2358e 
The property caches are not specific to the engine. The same object may
be exposed to other engines and still require its property cache. When
the clearing of the property caches on engine destruction was
introduced, the property caches were still engine-specific and we had no
choice but to clear them. Otherwise any further access would lead to a
dereference of a dangling pointer.

Furthermore, when clearing the JS wrapper for a QObject, check if it's
actually the wrapper being deleted. We don't want to clear some other
engine's wrapper.

Amends commit 749a721.
Amends commit c6b2dd8.

Pick-to: 6.11 6.10
Fixes: QTBUG-142514
Change-Id: I40bb1aeca65225d56cb1d2ff498f5f1722216a70
Reviewed-by: Fabian Kosmale <[email protected]>
@AhmadSamir
tst_QmlCppCodegen: replace QScopedPointer with std::unique_ptr [1/6]
3de6292 
Change-Id: I20452fa710162f279a61fbe64a007dc6133a2a3a
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
tst_QmlCppCodegen: replace QScopedPointer with std::unique_ptr [2/6]
ff1e9ec 
Change-Id: I302b8466f0769a5c75fc318893d75fc0c97ce498
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
tst_QmlCppCodegen: replace QScopedPointer with std::unique_ptr [3/6]
8d6c20c 
Change-Id: If7bc0c0ef340d8fa77fcb32c571b8138ed80223b
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
tst_QmlCppCodegen: replace QScopedPointer with std::unique_ptr [4/6]
f8ccdc2 
Change-Id: Ia710672db417ab16c62c0e24f972649e7f1de322
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
tst_QmlCppCodegen: replace QScopedPointer with std::unique_ptr [5/6]
256fefc 
Change-Id: I3847b2dffd27ff5b5442fa795b848ddd41bc17c8
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
tst_QmlCppCodegen: replace QScopedPointer with std::unique_ptr [6/6]
28c14a8 
Change-Id: Idbf6fb138b92e4c63ded3d621079ee07c19aec2a
Reviewed-by: Ulf Hermann <[email protected]>
Update dependencies on 'dev' in qt/qtdeclarative
d55ad6d 
Change-Id: Ie59d180e823a4d6bc7c3c7f6f95d27018ed9cfb0
Reviewed-by: Qt Submodule Update Bot <[email protected]>
@AhmadSamir
tests/*: port away from contextless 3-arg QObject::connect
57420b3 
Pick-to: 6.11 6.10
Task-number: QTBUG-116296
Change-Id: Icc82fbf1bda7ec940940171b5f7ed786e00a274c
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
src/qml*/: port away from contextless 3-arg QObject::connect
85599da 
Pick-to: 6.11 6.10
Task-number: QTBUG-116296
Change-Id: I53d24a7094e94eb9934593636c981f4a2453de93
Reviewed-by: Ulf Hermann <[email protected]>
@FriedemannKleint
qtquick-android.qdoc: Fix \summary
daa8bc4 
It needs to be enclosed in {}.

Pick-to: 6.11 6.10
Task-number: QTBUG-143282
Change-Id: Ib270a65e866c52377329aa006c1f96decc671223
Reviewed-by: Assam Boudjelthia <[email protected]>
@ulfhermannqt
QtQml: Do not instantiate components with missing required properties
e6b698c 
If a required property cannot be set, abort the initialization of the
object. Otherwise you end up with an object that's missing some of the
properties you've explicitly marked as required.

Also, accept extra properties in the object used to set required
properties without warning. In JavaScript, having extra properties in
objects, via prototypes or implicit properties created by the JavaScript
runtime is the norm rather than the exception.

[ChangeLog][QtQml][Important Behavior Changes] When instantiating an
object from QML using Component.createObject() and some of its required
properties cannot be set due to type mismatches, the object creation is
aborted now. This is in line with what happens if a required property is
missing altogether.

Change-Id: I59347f871dd12813c6f0bd5e43eb294094c3d80f
Reviewed-by: Sami Shalayel <[email protected]>
Qmlssl: Fix warning for documentation
2dd6409 
Replace false API with the correct API to link

Pick-to: 6.11
Change-Id: I7f48e42d104feae8f60b1eb592b96fe2e13a4917
Reviewed-by: Ivan Solovev <[email protected]>
@samishalayel
qqmlpluginimporter: unregister types for dynamic plugins
35d98a0 
Amends 97fe92b which forgot to call
unregisterTypes() when unloading dynamic plugins. Also add a test.

Pick-to: 6.11
Task-number: QTBUG-133755
Change-Id: I39c96efaa129d672853f89351ca117361fd5b1d8
Reviewed-by: Oliver Eftevaag <[email protected]>
@ulfhermannqt
Controls: Fix dependency for windows style
1911fe0 
The windows style depends on the fusion style, not the basic style.

Pick-to: 6.11 6.10 6.8
Fixes: QTBUG-143374
Change-Id: I10b96b3422220195afc9563aa4de14f05a281c9f
Reviewed-by: Mitch Curtis <[email protected]>
Reviewed-by: Lars Schmertmann <[email protected]>
@mitchcurtis
QQuickAbstractSpinBox: move duplicated d func code into helpers
98f6b4e 
Pick-to: 6.11
Change-Id: I188a3b93f32afdee3f47513c5cc6845de0d8cbdc
Reviewed-by: Oliver Eftevaag <[email protected]>
Reviewed-by: Xavier BESSON (Qt) <[email protected]>
@aavit
Extend curve renderer benchmark test
602a147 
Add individual benchmarks for the most important path processing
steps.

Change-Id: I83c7632a73ec6adab6ccee87c8a48061d22980c4
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
@aavit
Curve renderer: Fix filling of certain paths
39f8b90 
The algorithms to remove intersections and determine fill sides can
sometimes be confused by paths having overlapping line segments. The
optimization to only check the fill side of a single segment per
subpath can then yield wrong results, causing rendering errors.  Avoid
by detecting such cases and disabling that optimization for them.

Pick-to: 6.11 6.10
Fixes: QTBUG-143112
Change-Id: I869f182b8ea59b2c7f9c048553d3258d99f205c6
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
@iCristalrope
Compiler: Improve const correctness
e9fa98a 
The compiler doesn't change the function at all.

Change-Id: I06c07312bbf2ca3ebd8aaeb201c3d0776903cae5
Reviewed-by: Sami Shalayel <[email protected]>
@AhmadSamir
src/quick/items: port away from contextless 3-arg QObject::connect
918e54e 
Pick-to: 6.11 6.10
Task-number: QTBUG-116296
Change-Id: Ibe078b23358e6468c0cfb6da10c0763f170e65d8
Reviewed-by: Shawn Rutledge <[email protected]>
Reviewed-by: Ulf Hermann <[email protected]>
@AhmadSamir
src/quicktemplates: port away from contextless 3-arg QObject::connect
95bbb9c 
Pick-to: 6.11 6.10
Task-number: QTBUG-116296
Change-Id: I930502e62ec2033670f16d383635f71fc129f631
Reviewed-by: Ulf Hermann <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
Update dependencies on 'dev' in qt/qtdeclarative
e728c52 
Change-Id: I19d0936045b2c9fddc38e7099ca15b52b1580ea0
Reviewed-by: Qt Submodule Update Bot <[email protected]>
VectorImage: Fix compilation caused by pointers changes
2e27276 
Raw pointers were replaced by unique pointers in multiple
locations in Qt Svg, this will cause compilation issues here.

Pick-to: 6.11
Change-Id: Ia999f372f980f365493e8f19baa20911d3830a29
Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
Reviewed-by: Robert Löhning <[email protected]>
FluentWinUI3: Improve the ToolButton when using high contrast themes
8ebffb1 
The AppBar[Toggle]Button is the equivalent WinUI3 control.
Our ToolButton should have the same look and feel as the AppBar*
buttons both with and without enabling a high contrast theme.

Interestingly enough, these AppBar* buttons differs from the regular
buttons in that they look identical when they're pressed/hovered, and
checked. Furthermore, if they're both checked and hovered, they look
like a regular button that is hovered, but not checked.

To reduce the amount of logic in ButtonBackground.qml, we're now allowing
users of that object type to provide their own function for calculating
the background color.

Task-number: QTBUG-129088
Pick-to: 6.11 6.10
Change-Id: I891d5492f36a76ea187ffb3a5d4d03a033501623
Reviewed-by: Doris Verria <[email protected]>
@ulfhermannqt
QmlDom: Assert on validity of reference in resolveReference()
3a011b0 
Coverity-Id: 899159
Change-Id: I2bc3c6ac46496099a5bccae91e646ad1b47917de
Reviewed-by: Sami Shalayel <[email protected]>
@ulfhermannqt
tst_qquickcanvasitem: Skip test_paintContextInvalid() on QNX
99b2658 
This test is extremely slow on QNX and frequently hits the timeout.

Pick-to: 6.11 6.10 6.8
Task-number: QTBUG-143312
Change-Id: I85a3ede9854f162c9cae57f5be2b0e33dba389f9
Reviewed-by: Fabian Kosmale <[email protected]>
@ulfhermannqt
QtQml: Fix naming of memory statistics
ff61ed8 
The names were very misleading. We have regular items and large items.
We should call them what they are.

Change-Id: I7ae92f0c00120243dfb850a9d40a375ce970b249
Reviewed-by: Sami Shalayel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.